Skip to content

Storysource: Fix StyledSyntaxHighlighter to wrap long lines#22541

Merged
chakAs3 merged 6 commits into
nextfrom
chaks/fix-react-syntaxhighlighter-wrap
Jun 2, 2023
Merged

Storysource: Fix StyledSyntaxHighlighter to wrap long lines#22541
chakAs3 merged 6 commits into
nextfrom
chaks/fix-react-syntaxhighlighter-wrap

Conversation

@chakAs3

@chakAs3 chakAs3 commented May 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #15532

What I did

config StyledSyntaxHighlighter, in React storysource , wrapLongLines = true, in case of long Line the source will not be cut or hidden.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@shilman shilman changed the title React:StyledSyntaxHighlighter to wrap long lines Storysource: Fix StyledSyntaxHighlighter to wrap long lines May 22, 2023
shilman
shilman approved these changes May 22, 2023
View reviewed changes

@shilman shilman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @chakAs3

@shilman

shilman commented May 22, 2023

Copy link
Copy Markdown
Member

But it looks like TS is failing here https://app.circleci.com/pipelines/github/storybookjs/storybook/49431/workflows/3a173233-54ee-4a83-b245-b1d459b276ea/jobs/527505?invite=true#step-103-476

Can you please fix so we can merge?

@chakAs3

chakAs3 commented May 30, 2023

Copy link
Copy Markdown
Contributor Author

But it looks like TS is failing here https://app.circleci.com/pipelines/github/storybookjs/storybook/49431/workflows/3a173233-54ee-4a83-b245-b1d459b276ea/jobs/527505?invite=true#step-103-476

Can you please fix so we can merge?

Oh i did not see your comment. i will check it now

@chakAs3 chakAs3 requested a review from a team as a code owner June 2, 2023 14:29
@chakAs3 chakAs3 merged commit e0d42d6 into next Jun 2, 2023
@chakAs3 chakAs3 deleted the chaks/fix-react-syntaxhighlighter-wrap branch June 2, 2023 15:00
@shilman shilman mentioned this pull request Jun 4, 2023
Closed
@chakAs3 chakAs3 mentioned this pull request Jan 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shilman shilman shilman approved these changes

Assignees

@shilman shilman

Labels

addon: storysource bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Source: prettierConfig doesn't work

2 participants

@chakAs3 @shilman